Skip to content

Remove Playwright browser flow and tighten Rust/Python boundary - #86

Merged
zackees merged 1 commit into
mainfrom
remove-playwright-rust-boundary-cleanup
May 14, 2026
Merged

zackees merged 1 commit into
mainfrom
remove-playwright-rust-boundary-cleanup

Conversation

@zackees

@zackees zackees commented May 14, 2026 •

Copy link
Copy Markdown
Member

Summary

  • remove the Playwright browser package, CRX download helper, hidden chrome-extension CLI plumbing, and Playwright-based tests
  • remove --app and --legacy-browser; normal serve/watch and --serve-dir now launch the Tauri viewer directly
  • replace loose Rust/Python dictionary payloads and other weakly typed Python dict shapes with named dataclasses/structs where practical
  • route native build payloads through typed PyO3 objects instead of returning raw dictionaries across the Rust/Python boundary

Verification

  • soldr cargo fmt --check
  • python -m pyright src\fastled tests
  • python -m pytest tests\unit\test_post_migration.py tests\unit\test_build_service.py tests\unit\test_select_sketch_directory.py -q
  • soldr cargo test -p fastled-cli --quiet
  • soldr cargo test -p fastled-py --quiet
  • python -m pytest tests\integration\test_microphone_https.py -q

Refs #72
Refs #85

@zackees
zackees force-pushed the remove-playwright-rust-boundary-cleanup branch from 75c77d6 to a7463fa Compare May 14, 2026 08:45
@zackees
zackees merged commit d053dbd into main May 14, 2026
18 of 25 checks passed
@zackees
zackees deleted the remove-playwright-rust-boundary-cleanup branch November 5, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant